Skip to content

Fix attr cast for espidf #137620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix attr cast for espidf #137620

merged 1 commit into from
Feb 26, 2025

Conversation

@SergioGasquez
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 25, 2025
@SergioGasquez
Copy link
Contributor Author

r? @thomcc

@rustbot rustbot assigned thomcc and unassigned ibraheemdev Feb 25, 2025
@xizheyin
Copy link
Member

Looks good.

@ivmarkov
Copy link
Contributor

LGTM.

@ChrisDenton
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 26, 2025

📌 Commit 622b4fa has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2025
This was referenced Feb 26, 2025
Closed
Merged
@bors bors merged commit c5d5727 into rust-lang:master Feb 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 26, 2025
@SergioGasquez SergioGasquez deleted the fix/espidf-maybeunit branch February 27, 2025 08:37
@ivmarkov ivmarkov mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xizheyin xizheyin xizheyin approved these changes

Assignees

@thomcc thomcc

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

8 participants

@SergioGasquez @rustbot @xizheyin @ivmarkov @ChrisDenton @bors @thomcc @ibraheemdev